fix(action): unexpected behaviour when watching non-existing Actions #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passed an action with an unknown ID, the `ActionClient.WatchProgress()` and `ActionClient.WatchOverallProgress()` methods experience unexpected behaviour: - `WatchProgress()` would panic with a nil pointer dereference when accessing `a.Status` - `WatchOverallProgress()` would go into an infinite loop, never finishing or closing the channels.
apricote
added
the
backport release-1.x
jooola
approved these changes
Aug 8, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
…298) When passed an action with an unknown ID, the `ActionClient.WatchProgress()` and `ActionClient.WatchOverallProgress()` methods experience unexpected behaviour: - `WatchProgress()` would panic with a nil pointer dereference when accessing `a.Status` - `WatchOverallProgress()` would go into an infinite loop, never finishing or closing the channels. (cherry picked from commit 0727d42)
apricote
added a commit
that referenced
this pull request
Aug 8, 2023
…298) (#300) When passed an action with an unknown ID, the `ActionClient.WatchProgress()` and `ActionClient.WatchOverallProgress()` methods experience unexpected behaviour: - `WatchProgress()` would panic with a nil pointer dereference when accessing `a.Status` - `WatchOverallProgress()` would go into an infinite loop, never finishing or closing the channels. (cherry picked from commit 0727d42) Co-authored-by: Julian Tölle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passed an action with an unknown ID, the
ActionClient.WatchProgress()andActionClient.WatchOverallProgress()methods experience unexpected behaviour:WatchProgress()would panic with a nil pointer dereference when accessinga.StatusWatchOverallProgress()would go into an infinite loop, never finishing or closing the channels.